Repository navigation
Accept HTTP model providers on loopback and private addresses - #868
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
SaladDay
force-pushed
the
accept-http-model-providers-on-private-addresses
branch
from
October 25, 2026 06:34
1fbe0f6 to
74d8c81
Compare
A model provider base_url may now use HTTP when its host is a loopback or private IP address, so a local or LAN gateway works without a TLS terminator. A host name still needs HTTPS, because it can resolve to any address. Core admission and the Runtime's frozen-bundle check share the one rule in internal/modelprovider. Closes #416.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A model provider
base_urlmay now use HTTP when its host is a loopback or private IP address (127.0.0.0/8, ::1, 10/8, 172.16/12, 192.168/16, fc00::/7), so a local or LAN gateway works without a TLS terminator. A host name still needs HTTPS, because it can resolve to any address; link-local and public addresses still need HTTPS.internal/modelprovider.SchemeAllowedis the one rule. Core admission and the Runtime's frozen-bundle check both use it (the Runtime previously allowed loopback only).Closes #416.
Checks:
go test ./internal/modelprovider/ ./contracts/agents-api/v1/,go test ./internal/api/ -run ModelProvider(services/core), agents-client vitest (execution configuration, saved Agent defaults), Web typecheck and vitest (core errors, system).Need help on this PR? Tag
@codesmith-botwith what you need.