Repository navigation
fix: Usearch binary metrics - #81
Merged
Merged
Conversation
usearch counts the dimensions of binary metrics in bits and expects the vectors bit-packed into uint8, but the backend passed the array width as the number of dimensions, so every input raised a dimension mismatch. Binary metrics now take np.packbits vectors, reject other dtypes with a clear error, and report their width in bytes so insert accepts them.
stephantul
approved these changes
Sep 25, 2026
stephantul
left a comment
stephantul
left a comment
Contributor
There was a problem hiding this comment.
Lekker broodje hamming
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the hamming and tanimoto metrics in the usearch backend. Every input raised a dimension mismatch, because usearch counts binary dimensions in bits while the backend passed the array width. They now take uint8 vectors bit-packed with np.packbits, and other dtypes get a clear error.
Also added a trusted publishing release workflow.