fix: defer active compile directory cleanup - #101
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SandboxRunner.stop()from cleaning the active sketch/output directory while local compilation is still in progressRoot cause
markTempDirForCleanup()already defers cleanup whileisCompilingorlocalCompiler.isBusyis true.However,
SandboxRunner.stop()subsequently iterated all directories returned bygetCreatedSketchDirs()and calledattemptCleanupDir()directly.That bypassed the compile guard and could rename the active directory to
.cleanupwhile compilation still needed it.Observed production log symptom:
[RaceCondition] Output directory vanished before g++ spawn
Fix
While compilation is active, the direct tracked-directory cleanup loop skips only the active compile directory.
Other stale tracked directories continue to be cleaned.
After the compile settles, the existing deferred cleanup path processes the active directory and clears its tracking.
Regression coverage
The race test uses a controlled Promise and no timing sleeps.
Validation
npm run check: PASSnpm test: 2113/2113 PASSnpm run test:coverage: PASSnpm run test:integration: 13 PASS, 1 SKIPgit diff --check: PASSScope