Repository navigation
Fix activity section field alignment for Xcode 27 logs - #262
Open
Ckitakishi wants to merge 1 commit into
Open
Ckitakishi wants to merge 1 commit into
Ckitakishi wants to merge 1 commit into
Conversation
Ckitakishi
requested review from
aleksandergrzyb,
ecamacho and
polac24
as code owners
October 27, 2026 10:22
Ckitakishi
force-pushed
the
fix/activity-section-flags
branch
from
October 27, 2026 10:32
d746c81 to
688b744
Compare
Read resultCode before the Boolean flags in SLF 13 and later. Store the SLF 13 integer after attachments in the existing unknown field. Keep the command-line compatibility path for earlier formats. Preserve resultCode when replacing section messages. Update internal callers to pass the new argument explicitly. BREAKING CHANGE: IDEActivityLogSection.init now requires resultCode. Pass nil when no result code is available. Co-authored-by: Codex <codex@openai.com> Signed-off-by: Yuhan Chen <chenyuhan43@gmail.com>
Ckitakishi
force-pushed
the
fix/activity-section-flags
branch
from
October 27, 2026 11:46
688b744 to
0a2ad0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes activity section field alignment in Xcode 27 (SLF 13) logs. See #261 for details.
Field alignment
wasCancelledresultCodeisQuietwasCancelledwasFetchedFromCacheisQuietunknown(fallback)wasFetchedFromCacheChanges
For SLF 13 and later, the parser reads
resultCodebefore the Boolean fields and stores the integer after attachments inunknown. Section copies preserveresultCode.Breaking change
IDEActivityLogSection.initrequiresresultCodewithout a default so callers must explicitly handle the new field. Omitted arguments produce a compiler error. Passnilwhen no result code is available.Validation
swift test --disable-sandbox: 90 tests passed.resultCode, and Boolean fields.Fixes #261