Repository navigation
Materialize Swift import inputs for indexing - #3359
Open
karim-alweheshy wants to merge 2 commits into
Open
karim-alweheshy wants to merge 2 commits into
karim-alweheshy wants to merge 2 commits into
Conversation
added 2 commits
September 23, 2026 20:56
Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
Forward import-input metadata through both merged top-level and mixed-language target argument structs as soon as indexing consumes it. The integration example covers the command-line and C dynamic-library analysis paths. These assignments were previously delayed until the explicit-module follow-up. Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
karim-alweheshy
marked this pull request as ready for review
October 7, 2026 18:38
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Materialize the local Swift and Clang import inputs needed by Xcode indexing, including modules, module maps, headers, bridging-header inputs, and compiler plugins. Wire the collected inputs into the generated indexing preparation path; this does not expose native Preview configurations.
Validation
The diff adds Starlark tests for Swift explicit inputs and plugin inputs. Tests were not rerun for this description update.
Testing
Run
bazel test //test/internal/pbxproj_partials:swift_explicit_inputs //test/internal/pbxproj_partials:swift_plugin_inputsand verify ordinary compiler arguments remain unchanged. No Canvas render is claimed.