Repository navigation
Preserve link-response structure and paths - #3361
Draft
karim-alweheshy wants to merge 6 commits into
Draft
karim-alweheshy wants to merge 6 commits into
karim-alweheshy wants to merge 6 commits into
Conversation
added 4 commits
September 23, 2026 17:16
Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
Preserve the Bazel-owned response API while anchoring relative link inputs to the execution root. Cover the ordinary response grammar, test-host inputs, and multi-chunk T5 golden. Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
…review-05-link-responses Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
Base automatically changed from
preview-stack-link-groups
to
preview-stack-link-arguments
September 27, 2026 11:02
Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
karim-alweheshy
force-pushed
the
preview-stack-link-arguments
branch
from
October 7, 2026 11:46
87caab3 to
b81aa09
Compare
karim-alweheshy
force-pushed
the
preview-review-05-link-responses
branch
from
October 7, 2026 11:46
70e7d27 to
fa22a36
Compare
Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve linker argument structure and paths while parsing Bazel response files: handle multi-chunk inputs, response-file redirects, quoting, and generated product paths without dropping neighboring options. This remains an argument-processing change, not native Preview activation.
Stack
Based on #3350. Review this PR's delta against that parent; land the prerequisite first, then retarget and revalidate against
main.Validation
Regression tests cover response-file layout, quoting, exact library matching, and test-host inputs. Hosted checks reported success on the published head in the 2026-10-08 snapshot.
Testing
Run
bazel test //tools/params_processors:link_params_processor_tests. No Canvas render is claimed.