Repository navigation
Separate native Swift and framework-path ownership - #3363
Draft
karim-alweheshy wants to merge 3 commits into
Draft
karim-alweheshy wants to merge 3 commits into
karim-alweheshy wants to merge 3 commits into
Conversation
added 3 commits
September 23, 2026 20:58
Preserve ordinary/index flags while removing output bindings only from the native configuration. Detect actual profile-generation options, select Xcode-generated Swift headers for mixed targets, and keep required module sidecars. Public native opt-in remains disabled. Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
Follow actual PBX dependency edges before selecting native framework products. Pass distinct ordinary and native framework paths through the paired generator interface; retain Bazel paths for excluded dependencies and legacy builds. Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Separate native Swift output/profile arguments from Bazel compilation and resolve framework paths according to scheduled product ownership. Keep the public native Preview opt-in in a later change.
Stack
Based on #3362. Review this delta on its prerequisite, then retarget and revalidate against
mainafter it lands.Validation
The diff adds generator and target-setting regressions for native Swift output and profile behavior. Hosted checks reported success on the published head in the 2026-10-08 snapshot.
Testing
Run
bazel test //tools/generators/target_build_settings:target_build_settings_tests //test/internal/pbxproj_partials:write_target_build_settings. Confirm ordinary settings remain unchanged. This does not expose native Preview mode or claim Canvas rendering.