Skip to content

🐛Bugfix: model list provider mismatch, delete dialog errors, and password strength reset#3485

Open
ayiya12 wants to merge 3 commits into
developfrom
zjy/bugfix_project2
Open

🐛Bugfix: model list provider mismatch, delete dialog errors, and password strength reset#3485
ayiya12 wants to merge 3 commits into
developfrom
zjy/bugfix_project2

Conversation

@ayiya12

@ayiya12 ayiya12 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

PR Description

Summary

Three independent bug fixes:

  1. Fix [Bug] When adding models in batches, switching to video understanding models results in an incorrect model list. #3066
    Fix incorrect model list when switching provider during batch add — The three model-list hooks (useDashscopeModelList, useSiliconModelList, useTokenponyModelList) trigger their auto-fetch effect without checking form.provider, so switching providers lets the previous provider's stale request overwrite the new provider's model list. Fix: each hook now checks that form.provider matches before fetching.
image
  1. Fix [Bug] When the model's API key becomes invalid, the model cannot be properly deleted #2761
    Fix model deletion dialog showing garbage rows when API key is invalid — When a provider request fails, the backend didn't pass status_code, and the frontend rendered the error object as if it were model data, producing "ghost rows" in the delete dialog. Fix: the backend now attaches status_code on caught exceptions, and the frontend uses processProviderResponse to detect errors and clear the polluted state instead of rendering it.
image
  1. Fix [Bug] Need to reset password strength indicator when re-entering registration page after logout #3204
    Fix password strength indicator not resetting on re-entering register pageresetForm never cleared the local passwordValue state, so the strength indicator kept showing the previously entered password's strength. Fix: added setPasswordValue("") to the reset logic.
image

Changes

  • frontend/hooks/model/{useDashscopeModelList,useSiliconModelList,useTokenponyModelList}.ts — validate form.provider before auto-fetching
  • backend/services/providers/{dashscope,silicon,tokenpony}_provider.py — attach status_code on caught exceptions
  • frontend/app/[locale]/models/components/model/ModelDeleteDialog.tsx — use processProviderResponse to detect errors and clear state
  • frontend/components/auth/registerModal.tsx — clear passwordValue on reset

@ayiya12
ayiya12 requested review from Dallas98 and WMC001 as code owners July 24, 2026 03:06
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant