Repository navigation
Take item actions and the command list from the MOO - #167
Merged
Merged
Conversation
Item cards offered get, drop, wear and remove from strings written into the client. The MOO now lists, on each Char.Items item, the verbs the player can use on it, and the card offers one action per verb. A verb that needs more text (put ... in chest) fills the command input with the cursor in the gap instead of sending. The rehash command list stored every abbreviation of a command (r, re, rea, read) as a command of its own. It now stores the full name; prefix completion already covers the abbreviations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Item cards. The card offered Get, Drop, Wear and Remove from strings written into the client. The MOO now sends, on every
Char.Itemsitem, the verbs the player can use on it (verbs), and the card shows one button per verb.take #5) is sent on click.put … in chest) fills the command input, with the cursor in the gap, and is not sent.verbsgets no buttons. There is no built-in fallback.Command list. The MOO now answers
dns-com-awns-rehash-getcommands(it used to drop the request). The client stored every abbreviation of a command (r,re,rea,read) as its own command; it now stores the full name. Prefix completion already covers the abbreviations.Things you will notice
g/w/r/daccess keys on the old four buttons are gone, since the buttons are no longer fixed.MOO side (already live)
$interface_utils:all_verbs_for/visible_commands,Char.Itemsitem_for, andhandle_getcommandson the rehash package. Wire format is indocs/GMCP/mongoose-additions.md.Tested
npm test: 130 files, 1527 tests pass.npm run typecheckclean.verbs; the coffee table's card showed 18 actions; "Put … on" filled the input withput on #4665, cursor at 4; the command list held 949 names, withlookand withoutl/lo.