Skip to content

Send the build's git describe as the GMCP client version - #170

Merged
ctoth merged 1 commit into
masterfrom
feat/hello-build-version
Oct 6, 2026
Merged

ctoth merged 1 commit into
masterfrom
feat/hello-build-version

Conversation

@ctoth

@ctoth ctoth commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

What

Core.Hello sent version: '0.1' for every build. It now sends the build's git describe string, the same value Preferences shows (for example v0.7.0-670-g9d2d9f5a).

Why

The MOO's new @issue command attaches the reporter's client name and version to each report. With a fixed 0.1, a client bug report could not say which build it came from.

Checked

  • The MOO stores this value in $gmcp.client_info and returns it from $client_utils:client_version. Nothing there parses it as a number (searched the 2026-10-06 04:22 UTC database dump for client_version and client_info). The client name is unchanged, so using_official_client still matches.
  • npx vitest run src/gmcp/session.test.ts: 7 passed. The startup test now asserts the hello carries the commit string and that the string is not empty.
  • npm run typecheck and biome lint on the two files: clean.

Not checked

  • A live login with this build, and @issue showing the new version. That needs a deploy.

Core.Hello sent a fixed version '0.1', so the MOO could not tell one web build from another. It now sends the same commit string Preferences shows. Nothing in the MOO parses this value; it is stored and shown in @issue reports.
@ctoth
ctoth merged commit f9246db into master Oct 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant