Repository navigation
Send the build's git describe as the GMCP client version - #170
Merged
Merged
Conversation
Core.Hello sent a fixed version '0.1', so the MOO could not tell one web build from another. It now sends the same commit string Preferences shows. Nothing in the MOO parses this value; it is stored and shown in @issue reports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Core.Hellosentversion: '0.1'for every build. It now sends the build'sgit describestring, the same value Preferences shows (for examplev0.7.0-670-g9d2d9f5a).Why
The MOO's new
@issuecommand attaches the reporter's client name and version to each report. With a fixed0.1, a client bug report could not say which build it came from.Checked
$gmcp.client_infoand returns it from$client_utils:client_version. Nothing there parses it as a number (searched the 2026-10-06 04:22 UTC database dump forclient_versionandclient_info). The client name is unchanged, sousing_official_clientstill matches.npx vitest run src/gmcp/session.test.ts: 7 passed. The startup test now asserts the hello carries the commit string and that the string is not empty.npm run typecheckandbiome linton the two files: clean.Not checked
@issueshowing the new version. That needs a deploy.