ci: publish plugin marketplace on release#1205
Conversation
- Add plugin marketplace build step to release workflow - Upload marketplace artifacts to GitHub Release - Make build script skip missing sources gracefully
🦋 Changeset detectedLatest commit: bda4206 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bda420677c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| publish-plugin-marketplace: | ||
| name: Publish plugin marketplace | ||
| needs: release | ||
| if: needs.release.outputs.packages_published == 'true' |
There was a problem hiding this comment.
When a changesets publish only includes another workspace package, packages_published is still true, but apps/kimi-code/scripts/native/resolve-release.mjs emits should_publish=false and a fallback @moonshot-ai/kimi-code@<current package.json version> tag. This job will then upload the newly generated marketplace to the previous Kimi Code release (or fail if that tag is absent), so releases for e.g. the SDK/core can mutate the wrong release assets; use the Kimi Code-specific kimi_native_release/should_publish output for this job.
Useful? React with 👍 / 👎.
| run: | | ||
| # The artifact contains files directly under dist-plugin-marketplace/ | ||
| cd dist-plugin-marketplace | ||
| gh release upload "$RELEASE_TAG" marketplace.json --clobber |
There was a problem hiding this comment.
This new job downloads artifacts but never checks out the repository and does not pass --repo/set GH_REPO. I checked the gh manual (https://cli.github.com/manual/gh_help_environment): GH_REPO is the repository for commands that otherwise operate on a local repository, so from dist-plugin-marketplace after actions/download-artifact there is no local repo for gh release upload to infer and the upload fails before publishing any marketplace assets; add checkout or pass --repo ${{ github.repository }}.
Useful? React with 👍 / 👎.
1 participant
Automatically build and publish the plugin marketplace as part of the release workflow.