Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 6b47eee The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 78e23ae82b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Refreshing this with the upstream dependency now resolved: the Orca-side capability advertisement has landed. stablyai/orca#19512 merged on 2026-09-18 ( That closes the loop on the concern raised in the earlier review — the gating is on a capability Orca now actually advertises, not on an open upstream PR. Branch state: still |
Orca sets TERM_PROGRAM=Orca, which no branch recognises, so inline images fell back to the text placeholder. Orca supports the Kitty graphics protocol but only advertises it out-of-band via ORCA_IMAGE_PROTOCOL; require both signals so releases predating that advertisement keep the text fallback instead of reserving image rows nothing renders. The check sits with the other outer-terminal detectors, ahead of the KITTY_WINDOW_ID branch, because that variable leaks into Orca panes.
d92fbd7 to
6b47eee
Compare
|
Rebased onto current The conflict was structural, not semantic.
The Orca check now sits after Diff is a pure addition, Verification — full All 5 failures reproduce identically on unmodified
The two new Orca cases pass: Still zero required check runs on this fork head, so GitHub reports |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b47eee96f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| // Orca advertises Kitty graphics support through ORCA_IMAGE_PROTOCOL. Check it before | ||
| // outer-terminal detection because variables like KITTY_WINDOW_ID can leak into its panes. | ||
| if (termProgram === "orca" && process.env['ORCA_IMAGE_PROTOCOL'] === "kitty") { |
There was a problem hiding this comment.
This adds a new local capability-detection behavior to the vendored fork, but the commit leaves packages/pi-tui/UPSTREAM.md unchanged and none of its existing intent cards covers Orca image detection. The next upstream reconstruction therefore has no decision/why-not-in-app record telling maintainers to preserve this branch; add the mandatory intent card alongside the test before landing.
AGENTS.md reference: packages/pi-tui/AGENTS.md:L11-L17
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Related Issue
No Kimi issue. This completes client-side compatibility for stablyai/orca#11668 and stablyai/orca#11706.
Problem
Orca exports
TERM_PROGRAM=Orcaand is adding Kitty graphics support, but Kimi Code treats it as an unknown terminal and falls back to text instead of displaying inline images.What changed
Tested with
pnpm --filter @moonshot-ai/pi-tui test(716 passing) andpnpm --filter @moonshot-ai/pi-tui typecheck.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.