fix remote control multi endpoint still use default credentials - #3466
fix remote control multi endpoint still use default credentials#3466whz14 wants to merge 1 commit into
Conversation
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 807e0e95a5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| oauthKey: resolveKimiCodeOAuthKey({ | ||
| oauthHost: kimiCodeEnvOAuthHost(), | ||
| baseUrl: kimiCodeEnvBaseUrl(), | ||
| }), |
There was a problem hiding this comment.
Resolve the persisted OAuth ref before loading the token
When a user selects the global OAuth login (or another endpoint persisted in config.toml) without endpoint environment variables, both values passed here are undefined, so this derives the default mainland credential key. Login persists a scoped key from the configured baseUrl and OAuth ref, and normal runtime auth reads that configuration, so /remote-control will either claim the user is not logged in or use a stale credential from the wrong region. Load the persisted provider configuration through the SDK and apply the same runtime-auth resolution used by login/runtime before selecting the token slot.
AGENTS.md reference: apps/kimi-code/AGENTS.md:L45-L45
Useful? React with 👍 / 👎.
| resolveKimiTokenStorageName({ providerName: KIMI_CODE_PROVIDER_NAME }), | ||
| resolveKimiTokenStorageName({ | ||
| providerName: KIMI_CODE_PROVIDER_NAME, | ||
| oauthKey: resolveKimiCodeOAuthKey({ |
There was a problem hiding this comment.
Add a changeset for the user-visible credential fix
This changes shipped CLI behavior by making Remote Control select a different credential slot, but the commit contains no .changeset entry. Without the required CLI patch changeset, this user-visible bug fix will be omitted from the generated release changelog; add a short @moonshot-ai/kimi-code patch changeset.
AGENTS.md reference: AGENTS.md:L85-L85
Useful? React with 👍 / 👎.
Related Issue
Resolve #(issue_number)
Problem
What changed
Checklist
/approve).gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.