fix: treat stray files in the session directory as missing storage en… - #3546
Open
jekhy wants to merge 2 commits into
Open
fix: treat stray files in the session directory as missing storage en…#3546jekhy wants to merge 2 commits into
jekhy wants to merge 2 commits into
Conversation
…tries
A non-directory entry (e.g. a Finder .DS_Store) under sessions/<workspace>/
made the session index stat <entry>/state.json, which fails with ENOTDIR.
That errno fell through to storage.io_failed ("unrecognized I/O error"),
crashed projection/reconciliation, and killed `kimi -c` at startup.
Map ENOTDIR to storage.not_found and treat it like ENOENT in
FileStorageService read/mtime/size/delete paths so scans skip junk entries.
🦋 Changeset detectedLatest commit: da85dae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tries
A non-directory entry (e.g. a Finder .DS_Store) under sessions// made the session index stat /state.json, which fails with ENOTDIR. That errno fell through to storage.io_failed ("unrecognized I/O error"), crashed projection/reconciliation, and killed
kimi -cat startup.Map ENOTDIR to storage.not_found and treat it like ENOENT in FileStorageService read/mtime/size/delete paths so scans skip junk entries.
Related Issue
Resolve #3545
Problem
What changed
Checklist
/approve).gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.