Skip to content

refactor(chrono): modernize Chronometer API with template elapsed() method #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorganCaron merged 1 commit into from
Sep 19, 2026
+5 −4
Merged

refactor(chrono): modernize Chronometer API with template elapsed() method #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions modules/Chrono/Chronometer.mpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,10 @@ export namespace CppUtils::Chrono
m_end = Clock::now();
}

[[nodiscard]] inline auto getDuration() const
template<class Duration = typename Clock::duration>
[[nodiscard]] inline auto elapsed() const -> Duration
{
return m_end - m_start;
return std::chrono::duration_cast<Duration>(m_end - m_start);
}

private:
Expand Down
2 changes: 1 addition & 1 deletion modules/Log/ChronoLogger.mpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export namespace CppUtils::Log
return;
m_enabled = false;
m_chrono.stop();
m_callback(Chrono::durationToString(m_chrono.getDuration()));
m_callback(Chrono::durationToString(m_chrono.elapsed()));
}

private:
Expand Down
2 changes: 1 addition & 1 deletion tests/Chrono/Chronometer.mpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace CppUtils::UnitTest::Chrono::Chronometer
suite.addTest("Chronometer", [&] {
auto chrono = CppUtils::Chrono::Chronometer{};
chrono.stop();
auto string = CppUtils::Chrono::durationToString(chrono.getDuration());
auto string = CppUtils::Chrono::durationToString(chrono.elapsed());
suite.expect(not std::ranges::empty(string));
Logger::print("{}", string);
});
Expand Down
Loading