logstash: make redis host and TLS configurable for simple pipelines - #511
Open
Saeid-Abadi wants to merge 3 commits into
Open
logstash: make redis host and TLS configurable for simple pipelines#511Saeid-Abadi wants to merge 3 commits into
Saeid-Abadi wants to merge 3 commits into
Conversation
The simple input/output (and default redis) templates hardcoded host => localhost with no TLS option, so pipelines could only reach a co-located Redis in plaintext. Add logstash_redis_input_host, logstash_redis_output_host and logstash_redis_tls (defaults keep the previous behaviour: localhost, no TLS).
DocSmith validation requires every defaults variable to be present in meta/argument_specs.yml. Add specs for logstash_redis_input_host, logstash_redis_output_host and logstash_redis_tls.
Match the wording already present in the generated README so the DocSmith README drift check passes. Descriptions now note that input/output hosts also cover the built-in forwarder/input pipelines and that logstash_redis_tls toggles ssl/ssl_enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The simple input/output (and default redis) templates hardcoded host => localhost with no TLS option, so pipelines could only reach a co-located Redis in plaintext. Add logstash_redis_input_host, logstash_redis_output_host and logstash_redis_tls (defaults keep the previous behaviour: localhost, no TLS).