You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@vcnainala I would like to work on this. I have looked at nmr-correlation's actual API: buildCorrelationData(spectra, options) and the existing nmr-cli codebase already has everything needed to fetch/parse spectra from a URL (prase-spectra.ts), so this should mostly be wiring that into a new command, following the same pattern as peaks-to-nmrium.
One thing I need from you: nmr-correlation doesn't ship any built-in default tolerance values, the tolerance option is just an empty object if not provided. What should the default H/C tolerances be for this command? Happy to open a PR once I have that.
Activity
MuhammadAbeerAkmal commentedon Aug 31, 2026
@vcnainala I would like to work on this. I have looked at
nmr-correlation's actual API:buildCorrelationData(spectra, options)and the existingnmr-clicodebase already has everything needed to fetch/parse spectra from a URL (prase-spectra.ts), so this should mostly be wiring that into a new command, following the same pattern aspeaks-to-nmrium.One thing I need from you:
nmr-correlationdoesn't ship any built-in default tolerance values, thetoleranceoption is just an empty object if not provided. What should the default H/C tolerances be for this command? Happy to open a PR once I have that.vcnainala commentedon Aug 31, 2026
@MuhammadAbeerAkmal thank you for your interest. we can have the following default tolerance values