Skip to content

Chore: [AEA-0000] - bump dev container version to 1.4.8 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthony-nhs merged 2 commits into from
Apr 17, 2026
Merged

Chore: [AEA-0000] - bump dev container version to 1.4.8 #16

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9598f3
bump dev container version
anthony-nhs Apr 16, 2026
4feb592
fix
anthony-nhs Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
verify_published_from_main_image: false

quality_checks:
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@68c2dea999875055ecbfdf055d8391e6e8b8ce2f
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc
needs: [get_config_values]
permissions:
Comment on lines 17 to 20
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the quality-checks-devcontainer reusable workflow SHA was bumped here, but the tag_release job still points at the previous tag-release-devcontainer.yml@68c2.... If the devcontainer version bump to 1.4.8 is meant to apply end-to-end, consider bumping the tag-release-devcontainer SHA as well (or clarify why tagging should remain on the older version).

Copilot uses AI. Check for mistakes.
contents: "read"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
AUTOMERGE_PEM: ${{ secrets.AUTOMERGE_PEM }}

quality_checks:
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@68c2dea999875055ecbfdf055d8391e6e8b8ce2f
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc
needs: [get_config_values]
permissions:
Comment on lines 26 to 29
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This updates quality-checks-devcontainer to a new eps-common-workflows SHA, but tag_release in the same workflow still uses the older tag-release-devcontainer.yml@68c2.... If the intent is to bump the devcontainer version to 1.4.8, consider updating the tag-release-devcontainer reference too so the workflow is consistently using the new devcontainer tooling during tagging.

Copilot uses AI. Check for mistakes.
contents: "read"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
verify_published_from_main_image: false

quality_checks:
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@68c2dea999875055ecbfdf055d8391e6e8b8ce2f
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc
needs: [get_config_values]
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR bumps the eps-common-workflows ref for quality-checks-devcontainer, but the tag_release job in this workflow still references the older eps-common-workflows SHA for tag-release-devcontainer.yml. If the goal is to bump the devcontainer version to 1.4.8 across the pipeline, this likely leaves the tagging/release step on the previous devcontainer workflow version; consider updating tag-release-devcontainer.yml@... to the same (or corresponding) SHA as well so both jobs use the intended devcontainer version.

Copilot uses AI. Check for mistakes.
permissions:
contents: "read"
Expand Down