CCM-11188 Implement patch /letter/id API #128
Conversation
| ...(letterBase.reasonCode && { reasonCode: letterBase.reasonCode }), | ||
| ...(letterBase.reasonText && { reasonText: letterBase.reasonText }) | ||
| } | ||
| }; | ||
| }); |
There was a problem hiding this comment.
The OAS for the letter list endpoint doesn't include reason code or reason test - given that these would irrelevant to a letter list operation GET /letters
It is present on the get status GET /letter/{id}
This is probably fine in that PENDING letters won't have reason codes but might be worth additional caution
There was a problem hiding this comment.
The GET /letter OAS has reasonCode and reasonText in the response schema currently. If it's not supposed to return these then we need to tweak the OAS to reflect this
There was a problem hiding this comment.
Remove reasonCode and reasonText for get letters response
masl2
left a comment
masl2
left a comment
There was a problem hiding this comment.
Needs a pass to make sure the responses are in line with the OAS. Things I've spotted:
- GET /letters doesn't include reason data in the response
- Error responses need to match the OAS. e.g. Resource not found, Invalid request
- Not sure the 400 response has made it across from the GET changes into the OAS? (the spec doesn't seem to cover the LIMIT errors responses now)
|
|
|
||
| destination_arn = "arn:aws:logs:${var.region}:${var.shared_infra_account_id}:destination:nhs-main-obs-firehose-logs" | ||
|
|
||
| common_db_access_lambda_env_vars = { |
There was a problem hiding this comment.
nit picky but these are common envars, but not db specific anymore
8 participants
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.