CCM-11942 Fixing cross repo workflows#137
Merged
aidenvaines-cgi merged 3 commits intomainfrom Sep 1, 2025
Merged
Conversation
|
m-houston
approved these changes
Sep 1, 2025
simonlabarere
pushed a commit
that referenced
this pull request
Sep 10, 2025
francisco-videira-nhs
added a commit
that referenced
this pull request
Sep 18, 2025
* CCM-11602: Test * CCM-11602: letters schema * CCM-11602: letters schema * CCM-11602: Give get letters access to GSI * CCM-11602: GET Letters endpoint * CCM-11602: GET Letters endpoint * CCM-11602: GET Letters endpoint * CCM-11602: GET Letters endpoint * CCM-11602: GET Letters endpoint * CCM-11602: GET Endpoint sandbox updates * CCM-11602: Get enpoint tests * CCM-11602: Get enpoint safe header check * CCM-11602: Update sandbox * CCM-11602: Update sandbox * CCM-11602: Add logging * CCM-11602: Update sandbox * CCM-11602: Rename size parameter to limit * CCM-11602: Add validation for limit parameter * CCM-11602: increase Trivy scan timeout * CCM-11602: Add groupId * Correct target URL for main (#134) * CCM-11942 Fixing cross repo workflows (#137) * CCM-11942 Fixing cross repo workflows * CCM-11942 Fixing cross repo workflows * CCM-11942 Fixing cross repo workflows * CCM-11751: Use github release assests for shared modules call (#142) * CCM-11751: Use github release assests for shared modules call * CCM-11751: Use github release assests for shared modules call * CCM-11751: Use github release assests for shared modules call * CCM-11751: Use github release assests for shared modules call * CCM-11751: Fixing workflow trigger (#146) * CCM-11580: Updates for OAS Spec V1 (#139) * CCM-11580: OAS syntax fixes Remove 'requestedProductionStatus' from letter-related JSON schemas and update examples to singular form CCM-11580: Update serve-oas command CCM-11580: Update serve-oas command CCM-11580: Remove unneeded endpoints and resource types + Move getData endpoint under letter CCM-11580: Remove hello world endpoint CCM-11580: Remove hello world endpoint CCM-11580: Add sandbox handler metadata to endpoints CCM-11580: More fixes to examples syntax CCM-11580: Remove remaining reference to hello-world lambda CCM-11580: Remove remaining reference to hello-world lambda CCM-11580: add limit parameter to list letters endpoint CCM-11580: Update sandbox endpoints to match OAS CCM-11580: Update letter responses in Sandbox to match spec changes CCM-11580: implement get letter status endpoint in sandbox Add groupId to schema and examples * CCM-11580: remove x-eov extension from non sandox spec --------- Co-authored-by: mark.slowey1 <mark.slowey1@nhs.net> * Update README.md (#140) Small change to fix Sonar cloud badges * Add timestamp value to supplierStatusSk * CCM-11602: param validation, max range, and OAS 400 examples * CCM-11602: unit test expectation wording * CCM-11602: MAX LIMIT envar and added into test context * CCM-11602: limit can't be 0, return maxLimit value --------- Co-authored-by: David Wass <david.wass2@nhs.net> Co-authored-by: Aiden Vaines <54067008+aidenvaines-cgi@users.noreply.github.com> Co-authored-by: sidnhs <siddharth.nair1@nhs.net> Co-authored-by: Mike Houston <60653100+m-houston@users.noreply.github.com> Co-authored-by: mark.slowey1 <mark.slowey1@nhs.net> Co-authored-by: Tim Ireland <tim.ireland@hscic.gov.uk> Co-authored-by: Mark Slowey <113013138+masl2@users.noreply.github.com> Co-authored-by: Francisco Videira <francisco.videira@nhs.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
We found that multiple branches in this and some other repos which copy workflow ideas had started running in to challenges with build lockstep, race conditions and general instability.
The root cause seems to have been triggering remote workflows in several different ways.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.