Fix NPM access to packages in GitHub package registry#285
Merged
Conversation
This reverts commit f1444fd.
m-houston
force-pushed
the
feature/fix-github-npm-registry-access
branch
from
ea575c7 to
5741a86
Compare
m-houston
changed the title
masl2
approved these changes
Dec 5, 2025
francisco-videira-nhs
approved these changes
Dec 5, 2025
masl2
pushed a commit
that referenced
this pull request
Jan 5, 2026
* Add GitHub NPM registry configuration to .npmrc * Add version check and Node.js setup to CI workflow * Refactor event schema version checks in CI workflow * Add GitHub NPM registry URL to Node.js setup in workflows * Add NODE_AUTH_TOKEN to GitHub Actions environment for NPM access * Revert "Add GitHub NPM registry URL to Node.js setup in workflows" * Move NODE_AUTH_TOKEN to npm view step in CI workflow * Add NODE_AUTH_TOKEN to NPM install steps in workflows * Add NODE_AUTH_TOKEN input for GitHub package registry access in workflows * Add packages:read to permissions Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In order to direct package installs for @NHSDigital packages to the github package registry, we need to include it in the .npmrc file
Additionally, the CI workflow needs to be told to use the GITHUB_TOKEN for access to the relevant scope, which seems to be handled by the setup node action if you pass in the registry and provide the correct environment vars.
I've added a check to the commit workflow which runs if the schema changes: if the currently package.json version matches an already published version of the schemas then it will fail early, as otherwise this would fail during publishing when the pr_closed workflow runs.
You can see a forced run of this step failing (as intended) here.
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.