Merged
Conversation
m-houston
previously approved these changes
Jan 29, 2026
This was referenced Feb 5, 2026
Vlasis-Perdikidis
approved these changes
Mar 12, 2026
jamesthompson26-nhs
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces a new terraform variable to map to the source field of supplier api produced events.
This changes from deriving it from the terraform scaffold variables.
Implemented to allow greater control of this value and ensure it matches with the consuming domains' filters
Core and Supplier API source expectations did not match causing all supplier status updates to be filtered.
A hotfix was applied to PROD, this retrofits this fix to the trunk
Pairs with https://github.com/NHSDigital/nhs-notify-internal/pull/586
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.