feat: support MTP with context and pipeline parallelism - #3764
Draft
HuiyingLi wants to merge 1 commit into
Draft
Conversation
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Support the generic MTP + context-parallel + pipeline-parallel training combination, including the memory-saving fused linear cross-entropy path.
This is PR 2/3 in the HY4 support stack and depends on #3763. It contains only reusable training/parallelism infrastructure; no HY4 model code is included.
Changelog
FusedLinearCrossEntropy.Validation
GPU interactive allocation: Slurm job
16995628, H100 80GB.ruff checkandruff format --check: passed.The validation command covered:
tests/unit_tests/loss/test_mtp_lm_head_gather.pytests/unit_tests/moe/test_parallelizer.pytests/unit_tests/recipes/test_train_ft.pytests/unit_tests/shared/test_model_utils.pytests/unit_tests/models/nemotron_v3/test_nemotron_v3_pp_mtp.pytests/unit_tests/distributed/test_parallelizer_utils.pytests/unit_tests/test_validation.pytests/functional_tests/training/test_cp_flce_fsdp_correctness.pyBefore your PR is "Ready for review"
Pre checks:
Additional Information
Validation logs:
logs/hy_v4_prs/pr2-mtp-cp-pp-scoped-interactive-16995628.loglogs/hy_v4_prs/pr2-mtp-cp-pp-interactive-16995628.log