Repository navigation
Check active multimodal models before generation - #104
Open
oliverholworthy wants to merge 3 commits into
Open
oliverholworthy wants to merge 3 commits into
oliverholworthy wants to merge 3 commits into
Conversation
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run Data Designer's native
check_models()before multimodal generation, so a bad credential, unavailable model, or unreachable endpoint for a later judge fails before earlier stages incur generation costs.This runs automatically for each distinct active generator/judge configuration and any hosted summary embedding model. Shared deployments are checked once; generation batches skip repeat probes. Failed checks leave a new run unfrozen, and completed resumes still verify artifacts without credentials or model calls.
The checks make real text/embedding requests using the configured inference options. They verify basic provider readiness, not image support or judge schemas. Data Designer's
DATA_DESIGNER_SKIP_MODEL_HEALTH_CHECKS=1opt-out is respected.Validation:
UV_LINK_MODE=symlink make all— 942 passed, 2 optional Nemotron-consumer tests skipped; lint, plugin validation, generated-file checks, and docs passed. Regression coverage exercises the native readiness path with mocked model transport, including provider errors, routing, deduplication, embeddings, and resume integrity. No live model requests were used in validation.