Skip to content

build: bump Gym submodule to upstream main - #3979

Draft
ananthsub wants to merge 4 commits into
NVIDIA-NeMo:mainfrom
ananthsub:ananthsub/bump-gym-submodule
Draft

build: bump Gym submodule to upstream main#3979
ananthsub wants to merge 4 commits into
NVIDIA-NeMo:mainfrom
ananthsub:ananthsub/bump-gym-submodule

Conversation

@ananthsub

@ananthsub ananthsub commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • bump the Gym submodule from c3bac963 to upstream/main at cd28467d
  • keep Gym as an editable path dependency outside the uv workspace so its OpenAI 2.44 pin can resolve separately from SGLang's OpenAI 2.6.1 pin
  • regenerate uv.lock with the container's uv 0.11.28 and declare the nemo_gym/sglang extras conflict
  • pick up Gym's opt-in rollout-latency stamping fix for NeMo-RL direct callers

Test plan

  • uvx --from uv==0.11.28 uv lock --check
  • uv run pre-commit run --files uv.lock
  • CI:L1

Update Gym to 62cabfd4 and isolate its dependency source so uv can lock Gym's OpenAI 2.44 pin separately from SGLang's OpenAI 2.6.1 pin.

Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: 4f35adc (PR #3979 from ananthsub/bump-gym-submodule)

✅ Submodules that are properly updated:

Gym: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

@ananthsub ananthsub added algorithm CI:L2 Run doctests, unit tests, functional tests, and convergence tests CI:L1 Run doctests, unit tests, and functional tests and removed CI:L2 Run doctests, unit tests, functional tests, and convergence tests labels Sep 3, 2026
@ananthsub

Copy link
Copy Markdown
Contributor Author

/ok to test 4f35adc

Explicitly select the nemo-rl package so container builds resolve backend extras after Gym moves from a workspace member to an editable path dependency.

Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: cad1f30 (PR #3979 from ananthsub/bump-gym-submodule)

✅ Submodules that are properly updated:

Gym: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

@ananthsub

Copy link
Copy Markdown
Contributor Author

/ok to test cad1f30

Generate the split Gym and SGLang resolution with uv 0.11.28 so the container's frozen backend syncs can select their optional dependencies.

Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: 51bab64 (PR #3979 from ananthsub/bump-gym-submodule)

✅ Submodules that are properly updated:

Gym: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

@ananthsub

Copy link
Copy Markdown
Contributor Author

/ok to test 51bab64

Pick up Gym's opt-in rollout latency stamping fix for NeMo-RL direct callers and refresh the lockfile with the container's uv version.

Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
@ananthsub

Copy link
Copy Markdown
Contributor Author

/ok to test dd66081

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: dd66081 (PR #3979 from ananthsub/bump-gym-submodule)

✅ Submodules that are properly updated:

Gym: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

algorithm CI:L1 Run doctests, unit tests, and functional tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant