feat(vlm): support combined video and tracking GRPO - #3980
Draft
ehosseiniasl wants to merge 6 commits into
Draft
Conversation
ehosseiniasl
marked this pull request as ready for review
September 3, 2026 15:17
ehosseiniasl
force-pushed
the
ehsan/super35-latest-combined-video-minimal
branch
2 times, most recently
from
September 3, 2026 18:40
c9c056c to
4d043f9
Compare
ehosseiniasl
force-pushed
the
ehsan/super35-latest-combined-video-minimal
branch
from
September 3, 2026 22:16
4d043f9 to
fcc3033
Compare
ehosseiniasl
force-pushed
the
ehsan/super35-latest-combined-video-minimal
branch
2 times, most recently
from
September 4, 2026 15:33
9f1459a to
d5e2e86
Compare
Carry each row's logical media mode, processor-owned placeholder runs, and image tiling limits through dataset loading and NeMo Gym preprocessing. This keeps combined CAPRL video rows and SA-V image rows distinguishable without changing video-only behavior. Signed-off-by: ehosseiniasl <ehsan.hosseiniasl@gmail.com>
Offload routed-expert tensors as lazy per-message Ray references, preserve them through replay collation, and materialize only after policy microbatch slicing. Fail fast when R3 is requested but routes are missing, and keep reference scoring route-free. Signed-off-by: ehosseiniasl <ehsan.hosseiniasl@gmail.com>
Preserve explicit full-checkpoint loading, recursively apply rollout-only vision overrides, and cap dynamic image tiling consistently. Pause and resume the native async vLLM engine around in-flight refits so requests keep coherent weights and cache state. Signed-off-by: ehosseiniasl <ehsan.hosseiniasl@gmail.com>
When mtp_num_layers is zero, remove both legacy and unified repeated-layer MTP pattern metadata so MCore does not construct an inconsistent MTP block. Signed-off-by: ehosseiniasl <ehsan.hosseiniasl@gmail.com>
Document the mixed-data token-alignment failure and provide the validated Super Omni GRPO recipe with checkpoint-owned tokenizer, chat template, and media preprocessing settings. Signed-off-by: ehosseiniasl <ehsan.hosseiniasl@gmail.com>
ehosseiniasl
force-pushed
the
ehsan/super35-latest-combined-video-minimal
branch
from
September 4, 2026 20:32
d5e2e86 to
fff7ebb
Compare
ehosseiniasl
marked this pull request as draft
September 4, 2026 20:33
ehosseiniasl
force-pushed
the
ehsan/super35-latest-combined-video-minimal
branch
from
September 4, 2026 20:41
fff7ebb to
45979a8
Compare
ehosseiniasl
force-pushed
the
ehsan/super35-latest-combined-video-minimal
branch
from
September 4, 2026 20:52
45979a8 to
7d02a40
Compare
Signed-off-by: ehosseiniasl <ehsan.hosseiniasl@gmail.com>
ehosseiniasl
force-pushed
the
ehsan/super35-latest-combined-video-minimal
branch
from
September 4, 2026 21:01
7d02a40 to
4eca9e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
policy.get_logprobsbefore an optimizer step.Architecture
Scope clarification
Concrete examples
mcqa_simple_agent)input_imageitems tagged with_is_video_frame: trueand one_video_source.At what exact timestamp does the third and final sparring sequence begin? (A) [00:00] (B) [00:04] (C) [00:09] (D) [00:13] Please put the final answer within \\boxed{...}.\\boxed{...}.sav_pt_tracks_agent)Frame N:labels; tracked points may first appear in later frames.Track point 1 at (445, 624), point 2 at (34, 585) in frame 4, and point 3 at (32, 691) in frame 4. For every point and requested frame, report its 0-1000-grid location and visibility.<answer>{"tracks":[{"point":1,"frame":1,"xy":[x,y],"visible":true}]}</answer>.Why a recipe-only fix is insufficient
policy.get_logprobs.Resolution
load_format: auto, and use the checkpoint tokenizer plus its default chat template on both paths.mtp_num_layers=0, matching this checkpoint's actual non-MTP configuration.Validation on latest
super-v3.5-posttrainingBase:
3d4db49(fix(vlm): recognize Super Omni placeholder processor (#3989)).policy.get_logprobs, TMPE calculation (0masks), and backward. It then exhausted the deliberately small 8-GPU policy pool while allocating the first Adamexp_avg_sqbuffer; this is a topology capacity limit, not a media-alignment failure.0.375, mean TMPE1.0231, max TMPE1.0335, and steady-state step time51.0s. W&B0.4645, mean TMPE1.0152, max TMPE1.9197, masks0, step time545.1s. W&B0.016–0.054, while one rare token dominated the exponential TMPE statistic. The async batches had trajectory age 1; the synchronous run remains mask-free.git diff --checkpasses, and all six parent commits include DCO sign-offs.Scope
6bf9228changes 63 files with 4,485 additions. This latest-Super backport changes 39 files with 1,882 additions and keeps only the end-to-end mixed-media, vLLM/refit, R3, non-MTP, tests, documentation, and portable recipe pieces required by the validated runs.