feat: skip validation and reuse pre-converted arrow cache - #3983
Open
macandro96 wants to merge 2 commits into
Open
feat: skip validation and reuse pre-converted arrow cache#3983macandro96 wants to merge 2 commits into
macandro96 wants to merge 2 commits into
Conversation
Signed-off-by: Anish Mahishi <amahishi@nvidia.com>
Signed-off-by: Anish Mahishi <amahishi@nvidia.com>
macandro96
force-pushed
the
amahishi/hf-arrow-dataset-cache
branch
from
September 3, 2026 19:55
06f75ea to
6aff5f9
Compare
Contributor
Author
|
/ok to test 6aff5f9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Load NeMo Gym JSONL through Hugging Face’s reusable Arrow cache while preserving raw rows and supporting pre-converted Arrow/Parquet datasets; observed dataset setup improved from ~152 seconds to 2.2 seconds.
Skip validation dataset loading when validation is disabled, avoiding unnecessary duplicate data initialization while preserving validation and trajectory-collection behavior.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information