fix(refit): release trainer memory before collective export - #3984
Open
seonjinn wants to merge 2 commits into
Open
fix(refit): release trainer memory before collective export#3984seonjinn wants to merge 2 commits into
seonjinn wants to merge 2 commits into
Conversation
Signed-off-by: seonjinn <sna@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
seonjinn
marked this pull request as ready for review
September 3, 2026 22:01
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test ca43e3d |
Signed-off-by: seonjinn <sna@nvidia.com>
Contributor
Author
|
/ok to test 32b0467 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adds an opt-in trainer-memory release before default non-colocated vLLM collective refit. This avoids large MXFP8 exports, including Qwen3.5 397B, competing with completed gradient buffers, optimizer state, and Transformer Engine workspaces for trainer GPU memory.
The implementation reuses
policy.offload_before_refit(), supports GRPO and distillation, preserves the existing path by default, and rejects unsupported backend, topology, and transport combinations.Issues
N/A
Usage
Before your PR is "Ready for review"
Pre checks:
Additional Information
The option is disabled by default. It is supported for Megatron policy training with default non-colocated vLLM NCCL collective refit.