refactor(compute): negotiate external driver behavior - #2744
Open
drew wants to merge 3 commits into
Open
Conversation
drew
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
August 14, 2026 02:37
6 tasks
|
🌿 Preview your docs: https://nvidia-preview-pr-2744.docs.buildwithfern.com/openshell |
drew
marked this pull request as draft
August 14, 2026 03:04
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
drew
marked this pull request as ready for review
August 14, 2026 23:03
drew
marked this pull request as draft
August 14, 2026 23:05
drew
force-pushed
the
refactor/2417-external-driver-parity/drew
branch
from
August 17, 2026 06:05
eb4006a to
0801416
Compare
drew
marked this pull request as ready for review
August 17, 2026 06:05
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
drew
force-pushed
the
refactor/2417-external-driver-parity/drew
branch
from
August 18, 2026 07:03
daf85c9 to
680d1c2
Compare
15 tasks
elezar
reviewed
Aug 18, 2026
| string default_image = 3; | ||
| // Optional behavior supported by this driver instance. Unknown values are | ||
| // ignored and omitted features retain conservative gateway behavior. | ||
| repeated ComputeDriverFeature features = 6; |
Member
There was a problem hiding this comment.
Features are essentially binary flags, correct. Do we see the need for something richer?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make post-initialization compute-driver behavior depend on the public gRPC contract instead of concrete in-tree driver names. This stacked follow-up lets canonical driver names be supplied over UDS and negotiates whether the gateway owns graceful-shutdown/startup lifecycle reconciliation.
Related Issue
Closes #2417
Stacked on #2743.
Changes
GATEWAY_MANAGED_LIFECYCLEfrom Docker, Podman, and VM; Kubernetes and legacy external drivers remain opted outStopSandboxand startupStartSandboxsweeps--compute-driver-socket, with the explicit endpoint taking precedencedockernamedocs/changes are included in this PRTesting
mise run pre-commitOPENSHELL_E2E_DOCKER_TEST=gateway_start mise run e2e:dockermise run test: all completed suites passed except the unrelatedgateway_completer_returns_empty_when_no_config, which reproduces in isolation because this host has registered system gateway configurationChecklist