Skip to content

feat(podman): export driver traces over OTLP #2782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krishicks wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(podman): export driver traces over OTLP #2782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions crates/openshell-driver-podman/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ path = "src/main.rs"

[dependencies]
openshell-core = { path = "../openshell-core", default-features = false, features = ["driver-extraction"] }
openshell-otel = { path = "../openshell-otel" }

tokio = { workspace = true }
tonic = { workspace = true, features = ["transport"] }
Expand All @@ -32,11 +33,18 @@ nix = { workspace = true }
rustix = { workspace = true }
tracing = { workspace = true }
tracing-subscriber = { workspace = true }
tracing-opentelemetry = { workspace = true }
opentelemetry = { workspace = true }
opentelemetry_sdk = { workspace = true }
tower-http = { workspace = true }
http = { workspace = true }
thiserror = { workspace = true }
miette = { workspace = true }
url = { workspace = true }

[dev-dependencies]
opentelemetry-proto = { version = "0.32", default-features = false, features = ["gen-tonic", "trace"] }
opentelemetry_sdk = { workspace = true, features = ["testing"] }
prost-types = { workspace = true }
temp-env = "0.3"
tokio = { workspace = true, features = ["test-util"] }
Expand Down
6 changes: 6 additions & 0 deletions crates/openshell-driver-podman/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ driver runs in-process within the gateway server and delegates all sandbox
isolation enforcement to the `openshell-sandbox` supervisor binary, which is
sideloaded into each container via an OCI image volume mount.

When the gateway configures `[openshell.gateway.otlp]`, Podman compute-driver
spans export to the same OTLP/gRPC collector with the service name
`openshell-driver-podman`. The driver preserves the gateway trace context and
uses the same compute-driver RPC span names in its in-process and standalone
forms.

Before creating the container, the driver inspects the final sandbox image and
captures its immutable image ID and raw OCI `Config.User`. Container creation
uses that image ID with pulling disabled, preventing a mutable tag from changing
Expand Down
1 change: 0 additions & 1 deletion crates/openshell-driver-podman/src/container.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ use openshell_core::{driver_mounts, proto_struct};
use serde::Serialize;
use serde_json::Value;
use std::collections::{BTreeMap, HashSet};
#[cfg(target_os = "linux")]
use std::path::Path;

/// Returns `true` when `SELinux` is enabled (enforcing or permissive).
Expand Down
Loading
Loading