Skip to content

fix(cli): name the sandbox in service not-found errors - #3798

Merged
drew merged 3 commits into
NVIDIA:mainfrom
ericcurtin:fix/3736-service-sandbox-not-found
Oct 12, 2026
Merged

drew merged 3 commits into
NVIDIA:mainfrom
ericcurtin:fix/3736-service-sandbox-not-found

Conversation

@ericcurtin

@ericcurtin ericcurtin commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Service commands now name the sandbox in "sandbox not found" errors and say the first argument is the sandbox, not the service.

Related Issue

Fixes #3736

Changes

  • service_status_error takes the sandbox name and includes it in the error.
  • Drop the one-line service_expose_status_error wrapper.

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Fixes NVIDIA#3736

Signed-off-by: Eric Curtin <eric.curtin@docker.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 28, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ericcurtin

Copy link
Copy Markdown
Contributor Author

@krishicks @shailendra-nv PTAL when you get a chance. Thank you!

@ericcurtin

Copy link
Copy Markdown
Contributor Author

@mrunalp @johntmyers PTAL when you get a chance, and /ok to test 703638d7919a1f513c0e0a421451dec600b2da87 if it looks good. Thank you!

Signed-off-by: Eric Curtin <eric.curtin@docker.com>
@ericcurtin

Copy link
Copy Markdown
Contributor Author

Resolved the merge conflict with main. @mrunalp @johntmyers PTAL when you get a chance, and /ok to test 78ffb2a0f3c1c501a4477a7b0d7712fa5219e870 if it looks good. Thank you!

Signed-off-by: Eric Curtin <eric.curtin@docker.com>
@ericcurtin

Copy link
Copy Markdown
Contributor Author

Merged main and fixed the conflict. @mrunalp @johntmyers PTAL, and /ok to test ff513ce6d0ef53a8527c9cc0448037f9054d5365 if it looks good. Thank you!

@ericcurtin

Copy link
Copy Markdown
Contributor Author

@drew @elezar PTAL when you get a chance, and /ok to test ff513ce6d0ef53a8527c9cc0448037f9054d5365 if it looks good. Thank you! If useful, please also try https://github.com/llmmanorg/llmman, which can launch agents in an OpenShell sandbox (--sandbox openshell).

@drew

drew commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator

/ok to test ff513ce

@drew
drew enabled auto-merge October 12, 2026 05:40
@drew
drew added this pull request to the merge queue Oct 12, 2026
Merged via the queue into NVIDIA:main with commit 77c5ff6 Oct 12, 2026
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(cli): service delete reports 'sandbox not found' when given the service name — and sibling verb signatures are inconsistent

2 participants