Skip to content

[None][docs] drop deleted lm_eval_ad.py from auto_deploy README - #18959

Open
imitater-dou wants to merge 1 commit into
NVIDIA:mainfrom
imitater-dou:docs/drop-deleted-lm-eval-ad-auto-deploy-readme
Open

[None][docs] drop deleted lm_eval_ad.py from auto_deploy README#18959
imitater-dou wants to merge 1 commit into
NVIDIA:mainfrom
imitater-dou:docs/drop-deleted-lm-eval-ad-auto-deploy-readme

Conversation

@imitater-dou

@imitater-dou imitater-dou commented Sep 9, 2026

Copy link
Copy Markdown

Summary

Test plan

  • Confirmed examples/auto_deploy/lm_eval_ad.py is absent on current main (raw → 404)
  • Confirmed README no longer references lm_eval_ad.py
  • Docs-only change; no runtime tests required

Dev Engineer Review

The change removes obsolete instructions for the deleted examples/auto_deploy/lm_eval_ad.py script. It affects only documentation and introduces no runtime, API, configuration, or performance changes.

QA Engineer Review

No test changes.

Per-File QA Perspective

  • examples/auto_deploy/README.md: Verify that the obsolete command is absent and that the remaining AutoDeploy documentation and disclaimer retain the intended wording.

The AutoDeploy LM Evaluation Harness example script was removed in NVIDIA#7233;
the README still documented `python lm_eval_ad.py`, which 404s on main.

Signed-off-by: ADou <ikun3.1415927@gmail.com>
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b8a7ae38-6cdb-416f-ba70-899a2fce4d28

📥 Commits

Reviewing files that changed from the base of the PR and between 9504a60 and 2a48f4a.

📒 Files selected for processing (1)
  • examples/auto_deploy/README.md

Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review.


Walkthrough

The auto-deploy README removes the LM Evaluation Harness instructions and command example. The existing disclaimer remains unchanged.

Changes

Auto-deploy documentation

Layer / File(s) Summary
Remove evaluation instructions
examples/auto_deploy/README.md
The README removes the LM Evaluation Harness section and preserves the existing disclaimer.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 2a48f

This documentation cleanup removes a command for a deleted AutoDeploy evaluation script without changing product behavior or installation dependencies. No current merge-readiness risk remains.

Suggested reviewers: bowenfu

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the documentation change and the deleted lm_eval_ad.py reference. It is concise and related to the main change.
Description check ✅ Passed The description explains the stale documentation reference, the reason for removal, and the validation performed. It does not use the template headings or include the PR checklist, but it provides the…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant