[None][docs] fix visual_gen README cosmos3 and qwen-edit example paths - #18966
[None][docs] fix visual_gen README cosmos3 and qwen-edit example paths#18966imitater-dou wants to merge 1 commit into
Conversation
Retarget deleted models/cosmos3_ti2v.py to models/cosmos3/cosmos3.py and correct qwen-image-edit config from nonexistent fp4 YAML to fp8. Signed-off-by: ADou <ikun3.1415927@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 8 remain after this review. WalkthroughThe VisualGen README now uses the current Cosmos3 script, the FP8 Qwen image-edit configuration, and updated PNG, MP4, and AVI output-format guidance. ChangesVisualGen README updates
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to VisualGen documentation now points users to the current Cosmos3 script and supported FP8 Qwen image-edit configuration; no actionable current-head merge risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements. |
Summary
examples/visual_gen/models/cosmos3_ti2v.pyreferences tomodels/cosmos3/cosmos3.py(Cosmos3 example lives undermodels/cosmos3/).qwen-image-edit--visual_gen_argsconfig from nonexistentconfigs/qwen-image-edit-2511-fp4-1gpu.yamltoconfigs/qwen-image-edit-2511-fp8-1gpu.yaml.Verification
96a25c48b258: tree hasexamples/visual_gen/models/cosmos3/cosmos3.pyandconfigs/qwen-image-edit-2511-fp8-1gpu.yaml; nocosmos3_ti2v.pyand no fp4 edit YAML.cosmos3.pyaccepts--promptand defaults--modeltonvidia/Cosmos3-Nano.Signed-off-by: ADou ikun3.1415927@gmail.com
Dev Engineer Review
Updated README commands to reference
examples/visual_gen/models/cosmos3/cosmos3.pyand the existing FP8 Qwen configuration. Removed references to deleted or nonexistent paths. No runtime code changed.QA Engineer Review
No test changes.
Per-File QA Perspective
examples/visual_gen/README.md: Verify the commands from theexamples/visual_gendirectory. Confirm Cosmos3 generation, Qwen image editing with the FP8 configuration, and PNG, MP4, and AVI output formats.