[None][docs] fix multimodal chat client path in trtllm-serve docs - #18968
[None][docs] fix multimodal chat client path in trtllm-serve docs#18968imitater-dou wants to merge 1 commit into
Conversation
Multimodal serving only supports Chat API; point the literalinclude at openai_chat_client_for_multimodal.py (completion_* file does not exist). Signed-off-by: ADou <ikun3.1415927@gmail.com>
|
Closing as superseded by #18967, which covers the same multimodal |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 6 remain after this review. WalkthroughThe multimodal API documentation now references the OpenAI Chat API client example. The performance benchmarking reference remains unchanged. ChangesMultimodal Chat API documentation
Priority: ⚪ Not assessed Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to Multimodal serving documentation now directs users to the supported Chat API client example. No current merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
trtllm-servemultimodal docs claimed only Chat API is supported, but the Sphinxliteralincludepointed at nonexistentexamples/serve/openai_completion_client_for_multimodal.py.openai_chat_client_for_multimodal.pyand correct the surrounding “Completions API” wording to “Chat API” (matching the existingcurl_chat_client_for_multimodal.shexample).Test plan
examples/serve/openai_completion_client_for_multimodal.pyis absent on mainexamples/serve/openai_chat_client_for_multimodal.pyexistsDev Engineer Review
The documentation now references the existing
openai_chat_client_for_multimodal.pyexample and uses “Chat API” terminology. No runtime behavior changes are expected. A Sphinx build remains recommended.QA Engineer Review
No test changes.
Per-File QA Perspective
docs/source/commands/trtllm-serve/trtllm-serve.rst: Verify that the example link resolves and that the Chat API wording matches the supported multimodal serving interface.