[https://nvbugs/5836830][test] Remove DeepSeek-R1 W4AFP8 8-GPU quickstart test from QA list - #18979
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe pull request removes the DeepSeek R1 W4AFP8 eight-GPU PTP quickstart test from the QA test list and removes its corresponding skip configuration. ChangesDeepSeek PTP test cleanup
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change removes an OOM-prone quickstart test and its associated waive entry; no concrete merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
47b2e90 to
5d12195
Compare
…tart test from QA list test_ptp_quickstart_advanced_deepseek_r1_w4afp8_8gpus has been failing on Hopper (OOM while constructing the PyExecutor) and was SKIP-waived against nvbug 5836830. The bug is being retargeted to a later release and QA no longer needs this case in the core list. Remove the test from the QA core list and drop the now-orphaned waive. Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
|
/bot run |
5d12195 to
8e79b94
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
PR_Github #72544 [ run ] triggered by Bot. Commit: |
|
PR_Github #72544 [ run ] completed with state |
crazydemo
left a comment
crazydemo
left a comment
There was a problem hiding this comment.
Review summary - Approve
Reviewed the full diff; no blocking or major issues found.
Automated review by NVCortex Lite, run by @crazydemo.
|
Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements. |
4 participants
Summary
Removes
test_ptp_quickstart_advanced_deepseek_r1_w4afp8_8gpus[DeepSeek-R1-W4AFP8-DeepSeek-R1/DeepSeek-R1-W4AFP8]from the QA core test list and drops its now-orphaned SKIP waive.Why
The test has been failing on Hopper (OOM while constructing the PyExecutor) and was SKIP-waived against nvbug 5836830. The bug is being retargeted to a later release, and QA no longer needs this case in the core list. The test function itself in
test_e2e.pyis left intact.Changes
tests/integration/test_lists/qa/llm_function_core.txt— remove the test entrytests/integration/test_lists/waives.txt— remove the orphanedSKIP (https://nvbugs/5836830)waiveDev Engineer Review
Removes the failing DeepSeek-R1 W4AFP8 8-GPU test from the QA core list. Removes its obsolete nvbug 5836830 waiver. The test implementation remains intact, so no runtime code or API behavior changes occur.
QA Engineer Review
Removes
test_e2e.py::test_ptp_quickstart_advanced_deepseek_r1_w4afp8_8gpusfromtests/integration/test_lists/qa/llm_function_core.txt. Removes the matchingSKIPwaiver fromtests/integration/test_lists/waives.txt. The test function remains intests/integration/defs/test_e2e.py; no matching CItest-db/entry was identified. Coverage is sufficient.Per-File QA Perspective
tests/integration/test_lists/qa/llm_function_core.txt: Stops manual QA scheduling of the DeepSeek-R1 W4AFP8 8-GPU test, which fails with a Hopper OOM duringPyExecutorconstruction.tests/integration/test_lists/waives.txt: Removes the obsolete nvbug 5836830SKIPwaiver. No test behavior changes.