[https://nvbugs/6670516][fix] Call build_kv_page_indices with current signature - #18980
Conversation
…nature it has PR 17986 narrowed build_kv_page_indices from the req_to_token plus slot_ids pair to a single block_ids_cpu table and migrated its production caller. The three-argument callers that landed 47 minutes later in PR 17842 still passed four, so the two unit tests below raised TypeError on every run and were waived. PR 18106 has since repaired both tests, leaving the page-table microbenchmark as the last stale caller and the waivers with nothing to hide. Repoints the microbenchmark at the current helper, which already holds the block table the old code was expanding to token slots and folding back, and drops the three waivers. Unwaived: test_index_decode_score_matches_msa_proxy[dtype0], the same case at [dtype1], and test_sparse_decode_matches_msa_kernel. Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe change simplifies KV page-index construction in a minimax microbenchmark and removes three skip waivers for sparse MSA attention integration tests. ChangesIndex decode updates
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This updates the microbenchmark for the current page-index helper signature and re-enables repaired sparse MSA tests. No merge-blocking risk is evident. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run --disable-fail-fast |
|
PR_Github #72545 [ run ] triggered by Bot. Commit: |
|
PR_Github #72545 [ run ] completed with state |
|
Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements. |
Description
Fixed the last stale 4-arg
build_kv_page_indicescaller (the microbenchmark) and removed the waives. MR-18106 had already repaired the two waived tests.Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.Dev Engineer Review
_flat_page_tableto use the currentbuild_kv_page_indicessignature.QA Engineer Review
tests/integration/test_lists/waives.txt.Per-File QA Perspective
tests/microbenchmarks/minimax_m3_index_decode_score.py: Verify that the benchmark produces correct page indices with the currentbuild_kv_page_indicesAPI and preserves sparse decode behavior.tests/integration/test_lists/waives.txt: Verify that the three repaired sparse MSA attention tests run successfully after waiver removal.