Skip to content

[TRTLLMINF-368][infra] update cluster config for OCI-JHB - #18982

Merged
tburt-nv merged 1 commit into
NVIDIA:mainfrom
tburt-nv:user/tburt/jhb_prep
Sep 10, 2026
Merged

[TRTLLMINF-368][infra] update cluster config for OCI-JHB#18982
tburt-nv merged 1 commit into
NVIDIA:mainfrom
tburt-nv:user/tburt/jhb_prep

Conversation

@tburt-nv

@tburt-nv tburt-nv commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Description

OCI-JHB is configured similarly to OCI-AGA, and requires the same environment variables.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Dev Engineer Review

  • Updated oci-jhb* UCX settings to match oci-aga*.
  • The rule enables CUDA, shared memory, and TCP transports and prefers IPv4.
  • Added aws-dfw and oci-jhb to the documented cluster names.
  • Verify that OCI-JHB nodes support the selected transports.

QA Engineer Review

  • Modified tests/unittest/scripts/test_cluster_env.py.
  • Added coverage for oci-jhb-slurm-1 and its expected UCX environment export.
  • The test does not explicitly verify every configured transport or IPv4 preference.
  • No integration test-list changes apply.
  • Coverage verdict: needs follow-up.

Per-File QA Perspective

  • jenkins/scripts/perf/cluster_env.py: Verify the expected UCX settings and confirm that the wildcard matches only intended cluster names.
  • tests/unittest/scripts/test_cluster_env.py: Validates the OCI-JHB UCX export. This unit test does not require an integration test-list entry.

Signed-off-by: Tyler Burt <195370667+tburt-nv@users.noreply.github.com>
@tburt-nv

tburt-nv commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "unused new configuration"

@tburt-nv
tburt-nv enabled auto-merge (squash) September 9, 2026 22:47
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b57db84e-bf95-4fa8-b7dc-32af8dedf43c

📥 Commits

Reviewing files that changed from the base of the PR and between 5da0285 and ba4a837.

📒 Files selected for processing (2)
  • jenkins/scripts/perf/cluster_env.py
  • tests/unittest/scripts/test_cluster_env.py

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


Walkthrough

The cluster configuration adds aws-dfw and oci-jhb to the documented names. It adds an oci-jhb* UCX rule with CUDA, shared-memory, TCP, and IPv4 settings. A unit test verifies the configuration for oci-jhb-slurm-1.

Changes

OCI Johannesburg cluster support

Layer / File(s) Summary
Cluster naming and UCX configuration
jenkins/scripts/perf/cluster_env.py, tests/unittest/scripts/test_cluster_env.py
The documented cluster names include oci-jhb. The oci-aga* and oci-jhb* rules force cuda_ipc,cuda_copy,sm,self,tcp and set UCX_TCP_AF_PRIO=inet. Tests verify the oci-jhb-slurm-1 environment export.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to ba4a8

OCI Johannesburg clusters now receive the same CUDA, shared-memory, TCP, and IPv4 UCX settings as OCI AGA. The configuration behavior is covered by a targeted unit test, with no outstanding merge-readiness risk identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the infrastructure change for OCI-JHB and follows the required ticket and type format.
Description check ✅ Passed The description explains that OCI-JHB matches OCI-AGA and identifies the required environment variables. The Test Coverage section is empty, although the pull request includes a relevant unit test.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #72552 [ skip ] triggered by Bot. Commit: ba4a837 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #72552 [ skip ] completed with state SUCCESS. Commit: ba4a837
Skipping testing for commit ba4a837

Link to invocation

Comment thread jenkins/scripts/perf/cluster_env.py
@github-actions

Copy link
Copy Markdown

Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.

@tburt-nv
tburt-nv merged commit 8a931f6 into NVIDIA:main Sep 10, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants