[TRTLLMINF-368][infra] update cluster config for OCI-JHB - #18982
Conversation
Signed-off-by: Tyler Burt <195370667+tburt-nv@users.noreply.github.com>
|
/bot skip --comment "unused new configuration" |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. WalkthroughThe cluster configuration adds ChangesOCI Johannesburg cluster support
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to OCI Johannesburg clusters now receive the same CUDA, shared-memory, TCP, and IPv4 UCX settings as OCI AGA. The configuration behavior is covered by a targeted unit test, with no outstanding merge-readiness risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
|
PR_Github #72552 [ skip ] triggered by Bot. Commit: |
|
PR_Github #72552 [ skip ] completed with state |
|
Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements. |
Description
OCI-JHB is configured similarly to OCI-AGA, and requires the same environment variables.
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.Dev Engineer Review
oci-jhb*UCX settings to matchoci-aga*.aws-dfwandoci-jhbto the documented cluster names.QA Engineer Review
tests/unittest/scripts/test_cluster_env.py.oci-jhb-slurm-1and its expected UCX environment export.Per-File QA Perspective
jenkins/scripts/perf/cluster_env.py: Verify the expected UCX settings and confirm that the wildcard matches only intended cluster names.tests/unittest/scripts/test_cluster_env.py: Validates the OCI-JHB UCX export. This unit test does not require an integration test-list entry.