-
Notifications
You must be signed in to change notification settings - Fork 815
Thread tanh logit softcapping through FlashAttention (FA2, opt-in FA3) #3391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nvegesna-netizen
wants to merge
18
commits into
NVIDIA:main
Choose a base branch
from
nvegesna-netizen:nvegesna/gemma2-softcap-core
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
69b4ffb
feat: thread tanh logit softcapping through FlashAttention (FA2, opt-…
nvegesna-netizen 9839ae0
fix: use raise instead of assert for the ONNX+softcap guard
nvegesna-netizen eb215b5
[pre-commit.ci] auto fixes from pre-commit.com hooks
nvegesna-netizen 2475521
refactor: move softcap reference into UnfusedDotProductAttention and …
nvegesna-netizen 3c5eb4a
fix(pytorch): gate FA3 softcap on existing NVTE_FLASH_ATTN_V3
nvegesna-netizen 900371a
fix(pytorch): disable FlashAttention 4 for softcap
nvegesna-netizen 5ecabac
fix(pytorch): disable FlashAttention 2 for softcap with dropout
nvegesna-netizen 818ce26
Merge branch 'main' into nvegesna/gemma2-softcap-core
nvegesna-netizen 4cc2e9c
test: restore softcap dQ/dK/dV parity in the shared DPA harness
nvegesna-netizen 13d65a1
test: add softcap no-op and closed-form reference coverage
nvegesna-netizen 8be48f4
Merge branch 'main' into nvegesna/gemma2-softcap-core
nvegesna-netizen 55a6ed9
Merge branch 'main' into nvegesna/gemma2-softcap-core
nvegesna-netizen 8cb7f9c
Merge branch 'main' into nvegesna/gemma2-softcap-core
nvegesna-netizen 9ba7803
fix(pytorch): align CP autograd backward arity with the softcap forwa…
nvegesna-netizen db6a119
test(pytorch): cover context parallelism with softcap
nvegesna-netizen 49ede92
fix(pytorch): apply softcap before the additive bias, matching FlashA…
nvegesna-netizen 18f67b7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] bce4d3f
Merge branch 'main' into nvegesna/gemma2-softcap-core
nvegesna-netizen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.