[PyTorch] Fix EP zero-copy MXFP8 scale offset to be window-relative - #3447
Open
phu0ngng wants to merge 1 commit into
Open
[PyTorch] Fix EP zero-copy MXFP8 scale offset to be window-relative#3447phu0ngng wants to merge 1 commit into
phu0ngng wants to merge 1 commit into
Conversation
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Collaborator
Author
|
/te-ci L1 pytorch. |
Contributor
Greptile SummaryUpdates zero-copy expert-parallel communication to calculate symmetric-memory tensor positions relative to the NCCL window.
Confidence Score: 5/5The PR appears safe to merge because no concrete changed-code failure was established. The offset calculation now accounts for the NCCL window origin while preserving the separate storage offset needed for tensor views, and no incompatible reachable contract was identified. Important Files Changed
Reviews (1): Last reviewed commit: "[PyTorch] Fix EP zero-copy MXFP8 scale o..." | Re-trigger Greptile |
vthumbe1503
approved these changes
Aug 31, 2026
Collaborator
|
LGTM. Pending CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a brief summary of the changes, relevant motivation and context.
Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: