Fix GH action generated docs - #3449
Merged
Merged
Conversation
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
ptrendx
approved these changes
Aug 31, 2026
Contributor
Greptile SummaryThis PR makes the NVIDIA Sphinx theme’s public-site integrations configurable and disables them for GitHub Actions documentation builds, preventing persistent cookie prompts on non-docs.nvidia.com deployments.
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness or security issues identified. The workflow supplies the disabling value only for GitHub-hosted documentation builds, while other builds retain the previous enabled default, matching the domain-specific cookie behavior described by the change. Important Files Changed
Reviews (1): Last reviewed commit: "Fix GH docs" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue introduced in #3399, where
public_docs_featuresin the new theme makes the cookies not save on nondocs.nvidia.comdomains, resulting in continuous pop-up.Type of change
Changes
public_docs_featuresoff via envvar, and set this envvar in GH actions for a clean preview.Checklist: