Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
github-actions
Bot
added
the
cuda.core
Contributor
Author
|
/ok to test |
Contributor
|
Contributor
Author
|
/ok to test |
leofang
reviewed
Sep 18, 2026
| "embedsignature": True, | ||
| "warn.deprecated.IF": False, | ||
| "freethreading_compatible": True, | ||
| "annotation_typing": False, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A possible implementation of #2894.
This should give us something to discuss -- about whether this is an improvement or not.
My 2c -- keeping "semantically meaningful typing" separate from "annotation-only typing" has some upsides, but it creates additional redundancy that could be confusing.
As an aside, this did identify a few places where runtime type checking is performed multiple times unnecessarily, and in any event we should fix that.