Skip to content

Use default setuptools-scm tag parsing - #2922

Draft
rwgk wants to merge 2 commits into
mainfrom
rwgk/remove-custom-tag-regex
Draft

rwgk wants to merge 2 commits into
mainfrom
rwgk/remove-custom-tag-regex

Conversation

@rwgk

@rwgk rwgk commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Description

Removes the custom tag_regex settings from cuda-bindings, cuda-core, cuda-pathfinder, and cuda-python, allowing setuptools-scm to parse complete tag versions with its default parser. Also updates the corresponding wording in CONTRIBUTING.md.

The custom expressions primarily existed to strip rcN; that behavior conflicts with the current release validation, and partial regex matching can silently truncate unexpected suffixes. See the full rationale.

Validation

  • pre-commit run --all-files
  • Verified with setuptools-scm 10.2.3 that default parsing preserves rcN and .dev0, handles the cuda-core- and cuda-pathfinder- tag prefixes, and advances a .dev0 preview anchor correctly on a descendant commit.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rwgk rwgk added this to the cuda.bindings 13.5.0 & 12.9.10 milestone Sep 18, 2026
@rwgk rwgk added packaging Anything related to wheels or Conda packages cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module cuda.pathfinder Everything related to the cuda.pathfinder module labels Sep 18, 2026
@rwgk rwgk self-assigned this Sep 18, 2026
@copy-pr-bot

copy-pr-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module cuda.pathfinder Everything related to the cuda.pathfinder module packaging Anything related to wheels or Conda packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant