Skip to content

Fix logging bug when asking for more GPUs than available #1935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Bubullzz wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix logging bug when asking for more GPUs than available #1935

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cpp/cuopt_cli.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,8 @@ int main(int argc, char* argv[])
settings.get_pdlp_settings().num_gpus = requested_gpus;
}
if (requested_gpus > device_count) {
CUOPT_LOG_ERROR("num_gpus=%d exceeds the number of visible CUDA devices (%d).",
auto log = dummy_logger(settings);
CUOPT_LOG_ERROR("num-gpus=%d exceeds the number of visible CUDA devices: %d.",
requested_gpus,
device_count);
return -1;

@chris-maes chris-maes Sep 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to just issue the warning and continue the solve with the current available GPUs

Expand Down
Loading