-
Notifications
You must be signed in to change notification settings - Fork 526
Support NVIDIADriver reconciliation and driver upgrades without a ClusterPolicy #2572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
karthikvetrivel
wants to merge
1
commit into
main
Choose a base branch
from
kv-nvidiadriver-standalone
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct me if I am wrong, but in the scenario where both ClusterPolicy and GPUCluster exist, will the
.spec.hostPaths.rootFSfrom GPUCluster have the higher order of precedence?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ClusterPolicy takes precedence today. Now, I believe this combination is only valid when the ClusterPolicy sets
useNvidiaDriverCRD=true, and in that case ClusterPolicy'shostPaths.rootFSis used.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that this
hostRootvalue gets used hereThinking about this more, it doesn't make much sense to make this global value and we are better off getting this value from the
NVIDIADriverCR. For this, we would need to add a new field calledhostRootto the NVIDIADriver CR. This is the behaviour I envision in the following scenarios:GPUClusterresource is present (whether by itself or along withClusterPolicy, then we get the hostRoot from theNVIDIADriverCR, else we fallback to the GPUCluster hostRoot. Here we will never get the hostRoot fromClusterPolicy. This way we ensure zero dependency onClusterPolicyin aGPUClusterflowClusterPolicyis present, then we either get the hostRoot from theNVIDIADriver CR(the newly added field), else we fallback to theClusterPolicy.Spec.HostPaths.RootFSThis can be done in a follow-up PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that when we add
hostRootto the NVIDIADriver CR, it'll be an additive change and it will be an optional field. If this is empty, it will be defaulted to"/"as we currently do todayThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, the host root is needed for many of our daemonsets, not just the driver. So we still need this field to be present in the
GPUClusterCR. What is the benefit in having users configure this field in multiple places (GPUCluster and NVIDIADriver CRs)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the rest of the
HostPathsfields are used correctly in operands whether they come from GPUCluster or ClusterPolicy. For the driver daemonset however, it's just the.HostPaths.RootFSfield that is relevantThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in favor of moving
hostRoottoNVIDIADriverand removing it entirely fromGPUCluster.In the legacy
ClusterPolicypath, we can get thehostRootfrom eitherNVIDIADriverCR (if specified) or fromClusterPolicy.Spec.HostPaths.RootFSwhenuseNvidiaDriverCRD=true, and fromClusterPolicy.Spec.HostPaths.RootFSonly whenuseNvidiaDriverCRD=false.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussing internally, we have come to a consensus on how to move forward with this. The main issue we that we want to address (in a follow-up PR) is that there should be no cross-CR or circular dependency between the custom resources.
/for now.NVIDIADriverCRD or adding a new environment variable to determine the hostRoot to be set in both the driver daemonset and the DRA driver kubelet plugin daemonset. This is still ongoing.