add finaliser to GPUCluster CR using PATCH#2676
Open
tariq1890 wants to merge 1 commit into
Open
Conversation
tariq1890
requested review from
cdesiniotis,
karthikvetrivel,
rahulait,
rajathagasthya and
shivamerla
as code owners
July 24, 2026 23:19
tariq1890
force-pushed
the
ensure-finaliser
branch
from
July 24, 2026 23:26
2a9dde8 to
464c227
Compare
rahulait
reviewed
Jul 24, 2026
tariq1890
force-pushed
the
ensure-finaliser
branch
from
July 24, 2026 23:51
464c227 to
a4248cf
Compare
Contributor
Author
|
/ok to test a4248cf |
rahulait
approved these changes
Jul 25, 2026
tariq1890
force-pushed
the
ensure-finaliser
branch
from
July 25, 2026 00:09
a4248cf to
dbcd292
Compare
Contributor
Author
|
Thanks for the review @rahulait. I updated the PR to address a review comment from Claude and also added unit tests |
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com> Co-authored-by: Rajath Agasthya <ragasthya@nvidia.com>
tariq1890
force-pushed
the
ensure-finaliser
branch
from
July 25, 2026 00:11
dbcd292 to
312d215
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new util method to add a finaliser to the GPUCluster custom resource. It also uses
PATCHto add the finaliser as it's safer and more robuse to race conditions around object updates.h/t to @rajathagasthya for pointing me to the method in CAPI that inspired this change