chore(version): v19.7.0 - #187
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release commit for v19.7.0, generated with
cog --config .cog.toml bump --autoand then givenits hand-written
### Highlightssection, matching how v19.6.0 was prepared.Why a minor, not a patch
Four of the eight commits since v19.6.0 are
feat(...), andcog bump --autoindependentlyresolves to
v19.7.0. A patch number would under-report the release: it addsParaxialPinholeGeometry,register_camera_model_parameters,register_lidar_model_parameters,three exported abstract lidar bases, and a new requirement on concrete parameter subclasses. A
consumer pinned
>=19.6.0,<19.7would otherwise pick all of that up silently.Contents
.bazelrcembed_label19.6.0 -> 19.7.0, which is what the published wheel version followsCHANGELOG.mdWhat consumers should know
encode_*alreadywrote from
type(), including payloads using the retiredpinholeidentifier, and untaggedexternal distortion payloads. This was verified across versions: a payload encoded by the
published 19.6.0 wheel decodes under this tree to the same class and the same values.
decode_*and of themodel_parametersaccessors now receive the abstract base and may need anisinstancenarrowbefore reading a model-specific field. Measured against the two largest internal consumers: no new
type errors in either.
type, and camera onesparaxial_pinhole_geometry. Every model in this repository does, and no out-of-tree model existsyet, which is why the requirement is being stated now rather than defaulted.
Verification
bazel test //ncore/... //tools/...with--nocache_test_results: 34/34 pass on the releasetree
bazel run //:format.checkclean; the ty lint aspect passes on every targetembed_labelconfirmed at 19.7.0, which the wheel version derives fromTagging is handled by the GitHub release / CI, per
.cog.toml'spost_bump_hooks, so no tag ispushed here.
🤖 Generated with Claude Code