Skip to content

chore(version): v19.8.0 - #189

Merged
janickm merged 1 commit into
NVIDIA:mainfrom
janickm:dev/janickm/release-v19.8.0
Sep 15, 2026
Merged

janickm merged 1 commit into
NVIDIA:mainfrom
janickm:dev/janickm/release-v19.8.0

Conversation

@janickm

@janickm janickm commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Release commit for v19.8.0, generated with cog --config .cog.toml bump --auto and then given
its hand-written ### Highlights section, matching how v19.6.0 and v19.7.0 were prepared.

Exactly one change since v19.7.0: #188, the lidar field-of-view contract.

Why a minor, not a patch

cog bump --auto resolves to v19.8.0 on its own, because the single commit is a feat. That is
the right reading: the release adds two abstract methods to the public LidarModelParameters base
and requires every concrete lidar parameter class to implement them. A consumer pinned
>=19.7.0,<19.8 would otherwise pick that up silently under a patch number.

Contents

.bazelrc embed_label 19.7.0 -> 19.8.0, which is what the published wheel version follows
CHANGELOG.md generated entry plus the hand-written highlights

What consumers should know

  • Concrete lidar parameter classes must implement get_vertical_fov and get_horizontal_fov. Every
    model in this repository does, and no out-of-tree lidar model exists, so nothing outside this
    repository is affected.
  • No serialized format changed, and no existing signature changed. The two methods keep their
    released spelling, including the dtype parameter.

Verification

  • bazel test //ncore/... //tools/... with --nocache_test_results: 34/34 pass on the release
    tree
  • bazel run //:format.check clean; the ty lint aspect passes on every target
  • embed_label confirmed at 19.8.0, which the wheel version derives from

Tagging is handled by the GitHub release / CI, per .cog.toml's post_bump_hooks, so no tag is
pushed here.

🤖 Generated with Claude Code

@janickm
janickm added this pull request to the merge queue Sep 15, 2026
Merged via the queue into NVIDIA:main with commit dde366e Sep 15, 2026
5 checks passed
@janickm
janickm deleted the dev/janickm/release-v19.8.0 branch September 15, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant