chore(version): v19.8.0 - #189
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release commit for v19.8.0, generated with
cog --config .cog.toml bump --autoand then givenits hand-written
### Highlightssection, matching how v19.6.0 and v19.7.0 were prepared.Exactly one change since v19.7.0: #188, the lidar field-of-view contract.
Why a minor, not a patch
cog bump --autoresolves tov19.8.0on its own, because the single commit is afeat. That isthe right reading: the release adds two abstract methods to the public
LidarModelParametersbaseand requires every concrete lidar parameter class to implement them. A consumer pinned
>=19.7.0,<19.8would otherwise pick that up silently under a patch number.Contents
.bazelrcembed_label19.7.0 -> 19.8.0, which is what the published wheel version followsCHANGELOG.mdWhat consumers should know
get_vertical_fovandget_horizontal_fov. Everymodel in this repository does, and no out-of-tree lidar model exists, so nothing outside this
repository is affected.
released spelling, including the
dtypeparameter.Verification
bazel test //ncore/... //tools/...with--nocache_test_results: 34/34 pass on the releasetree
bazel run //:format.checkclean; the ty lint aspect passes on every targetembed_labelconfirmed at 19.8.0, which the wheel version derives fromTagging is handled by the GitHub release / CI, per
.cog.toml'spost_bump_hooks, so no tag ispushed here.
🤖 Generated with Claude Code