Keep feature category alignment in benchmarks - #986
cedric-lorenz wants to merge 1 commit into
Conversation
ae30587 to
335ab3c
Compare
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: NVIDIA/structured-data-models/.coderabbit.yaml Review profile: QUIET Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 SummarySummary by CodeRabbit
Walkthrough
ChangesTabular recipe
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Merge Risk: ⚪ Minimal · up to The change preserves feature category alignment for benchmark inputs while avoiding unnecessary target alignment. No actionable merge-blocking risk was found. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
BeyondArena failed with
Expected the category vocabulary ... to matchbecause train and test features used independent categorical vocabularies.Keep
AlignCategoriesin the feature pipeline to map query categories onto the fitted training vocabulary before categorical processing.