Skip to content

chore: pnpm lint does not lint e2e and scripts, where e2e/graphics has 7 eslint errors #518

Open

Description

@Exeloo

Which package is this bug report for?

other

Issue description

pnpm exec eslint e2e reports 7 @typescript-eslint/no-non-null-assertion errors in e2e/graphics/game-3d.spec.ts (lines 36, 37) and e2e/graphics/helpers.ts (lines 37, 51, 61). The root pnpm lint (prettier --check . then turbo run lint) never lints e2e/ or scripts/, so these errors pass CI unseen, and any new file there is unchecked.

Found by the style review of #516.

Code sample

No response

Versions

  • engine main ed8c7e0
  • eslint from the repo's lockfile

Issue priority

Low (slightly annoying)

I have tested this issue on a development release

ed8c7e0

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions