Skip to content

ci: move to the shared nanoforge-dev/actions v3 workflows - #464

Merged
Exeloo merged 6 commits into
mainfrom
ci/actions-v3
Nov 6, 2026
Merged

Exeloo merged 6 commits into
mainfrom
ci/actions-v3

Conversation

@Exeloo

@Exeloo Exeloo commented Nov 6, 2026

Copy link
Copy Markdown
Member

What does this PR do?

No linked issue: the migration was requested directly (move engine to the current NanoForge-dev/actions main, release 3.1.1).

Moves engine CI from the v2 npm package @nanoforge-dev/actions to the shared v3 reusable workflows (nanoforge-dev/actions/.github/workflows/*.yml@v3), configured in the new .github/nanoforge.json. Also cleans up the package changelogs so breaking changes are listed together.

.github/nanoforge.json         new: groups engine + utils, docs (category engine, references)
  engine  13 runtime packages, mode all, shared, tag {version},
          branch releases/nanoforge@{version}, commit "chore: release @nanoforge-dev/engine@{version}"
  utils   eslint/prettier configs, mode single, independent, tag {package}@{version}
.github/workflows/
  release-pr.yml               new, replaces pre-release.yml + pre-release-single.yml (group input)
  release.yml                  reusable release (npm, tags, GitHub release, docs sync with the docs app)
  alpha-release.yml            reusable alpha (packages input)
  tests.yml                    reusable tests (lint, unit + coverage, vitest e2e, audit)
                               + graphics e2e kept on ubuntu-24.04 with update-snapshots
  pr-triage / issue-triage / label-sync   templates from actions
.github/actions/prepare        nanoforge-dev/actions/setup@v3, then emsdk, then build
.github/actions/emsdk-install  swap step dropped (setup adds it)
package.json, pnpm-*           v2 @nanoforge-dev/actions removed
*/cliff.toml                   breaking notes on one line; every breaking commit in "Breaking Changes"
.github/CONTRIBUTING.md        Releases section

How do you test this PR?

  • Before: the release and alpha workflows called ./node_modules/@nanoforge-dev/actions/actions/* (v2), and docs were pushed with ACTIONS_KEY, which failed with Bad credentials on 2.0.0 (Engine 2.0.0 docs and API references never synced to the docs site #462).
    After: they call the v3 reusable workflows. The config loads with the actions' own loadConfig (both groups resolve as listed above).
  • Commands run:
    • docker run rhysd/actionlint:1.7.7: pass
    • prettier --check: pass
    • pre-push hook on b3e8aa2: pnpm build, pnpm lint, pnpm test:unit, pnpm test:e2e: all pass
    • git-cliff 2.13.1 on a scratch repo with packages/core/cliff.toml: feat!, fix! and chore! land in "Breaking Changes", and the breaking note keeps its first paragraph on one line
    • pnpm audit --audit-level high: fails (10 high, 2 critical); the new audit job stays red until Dependency audit fails at high: bump vulnerable dependencies #463
  • Not run: a release-pr dry run (needs Actions). Before the first real release, run Release PR with dry-run for engine and for utils.

Merge danger

Door: two-way (workflow and config files revert cleanly; the first real release afterwards is one-way: npm publishes and tags)
Blast radius: CI only. Engine CI and changelogs; bun scripts/graph.ts query engine lists 0 runtime dependents. Nothing deploys on merge. Squash merge this PR so only the ci: title reaches main.

Before or right after merging, on GitHub:

  • The NANOFORGE_DOCS_PRIVATE_KEY secret and NANOFORGE_DOCS_CLIENT_ID variable must be visible to Engine, with the docs app installed on docs. Otherwise the docs sync is skipped with a warning. ACTIONS_KEY can be deleted afterwards.
  • Required checks are renamed: Tests / Coding style (lint), Tests / Unit tests, Tests / End-to-end tests, Graphics e2e tests, Triage / Label, Triage / Validate title. Leave Tests / Dependency audit out of the required checks until Dependency audit fails at high: bump vulnerable dependencies #463.

Quality gate

Lane Result
Correctness pass. The reviewer's notes are fixed (leftover template comment dropped; the breaking parser moved to the top). GitHub settings above to do.
Security pass. Explicit secrets, no secrets: inherit, persist-credentials: false, no ${{ }} in run:
Style pass
Performance n/a (CI and changelog config)
Accessibility n/a (no UI)

Follow-up issues

@github-actions github-actions Bot added packages:common Related to Common library packages:core Related to Core library utils:prettier-config Related to Prettier config utils:eslint-config Related to ESLint config modules:ecs Related to ECS library modules:editor Related to Editor library modules:graphics-2d Related to Graphics2D library modules:input Related to Input library modules:music Related to Music library modules:network Related to Network library modules:sound Related to Sound library packages:asset Related to AssetManager library packages:env Related to Env library modules:scene Related to Scene library modules:graphics-3d Related to Graphics3D library labels Nov 6, 2026
@Exeloo
Exeloo merged commit b9bab84 into main Nov 6, 2026
6 of 7 checks passed
@Exeloo
Exeloo deleted the ci/actions-v3 branch November 6, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

modules:ecs Related to ECS library modules:editor Related to Editor library modules:graphics-2d Related to Graphics2D library modules:graphics-3d Related to Graphics3D library modules:input Related to Input library modules:music Related to Music library modules:network Related to Network library modules:scene Related to Scene library modules:sound Related to Sound library packages:asset Related to AssetManager library packages:common Related to Common library packages:core Related to Core library packages:env Related to Env library utils:eslint-config Related to ESLint config utils:prettier-config Related to Prettier config

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant