Repository navigation
ci: move to the shared nanoforge-dev/actions v3 workflows - #464
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
No linked issue: the migration was requested directly (move engine to the current
NanoForge-dev/actionsmain, release 3.1.1).Moves engine CI from the v2 npm package
@nanoforge-dev/actionsto the shared v3 reusable workflows (nanoforge-dev/actions/.github/workflows/*.yml@v3), configured in the new.github/nanoforge.json. Also cleans up the package changelogs so breaking changes are listed together.How do you test this PR?
./node_modules/@nanoforge-dev/actions/actions/*(v2), and docs were pushed withACTIONS_KEY, which failed withBad credentialson 2.0.0 (Engine 2.0.0 docs and API references never synced to the docs site #462).After: they call the v3 reusable workflows. The config loads with the actions' own
loadConfig(both groups resolve as listed above).docker run rhysd/actionlint:1.7.7: passprettier --check: passb3e8aa2:pnpm build,pnpm lint,pnpm test:unit,pnpm test:e2e: all passpackages/core/cliff.toml:feat!,fix!andchore!land in "Breaking Changes", and the breaking note keeps its first paragraph on one linepnpm audit --audit-level high: fails (10 high, 2 critical); the new audit job stays red until Dependency audit fails at high: bump vulnerable dependencies #463release-prdry run (needs Actions). Before the first real release, run Release PR withdry-runforengineand forutils.Merge danger
Door: two-way (workflow and config files revert cleanly; the first real release afterwards is one-way: npm publishes and tags)
Blast radius: CI only. Engine CI and changelogs;
bun scripts/graph.ts query enginelists 0 runtime dependents. Nothing deploys on merge. Squash merge this PR so only theci:title reachesmain.Before or right after merging, on GitHub:
NANOFORGE_DOCS_PRIVATE_KEYsecret andNANOFORGE_DOCS_CLIENT_IDvariable must be visible to Engine, with the docs app installed ondocs. Otherwise the docs sync is skipped with a warning.ACTIONS_KEYcan be deleted afterwards.Tests / Coding style (lint),Tests / Unit tests,Tests / End-to-end tests,Graphics e2e tests,Triage / Label,Triage / Validate title. LeaveTests / Dependency auditout of the required checks until Dependency audit fails at high: bump vulnerable dependencies #463.Quality gate
secrets: inherit,persist-credentials: false, no${{ }}inrun:Follow-up issues